Fix potential undefined behavior in ArrayQueue initialization #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
ArrayQueue::new()
would previously create temporary referencesto uninitialized data, which is undefined behavior. The stamps for the
Slot
buffer were initialized like so:As I see it, the code above creates a temporary reference to the uninitialized
Slot
s on the call toptr::write()
, equivalent to the following:The problem was fixed by creating the
slots
vector usingIterator::collect()
. This has the extra benefit of removing an unnecessaryunsafe
block.The same issue was present in the bounded flavor for
crossbeam-channel
, to which I applied the same change.For reference, see the nomicon: